[PATCH v4 5/6] ntdll: Clarify NtMapViewOfSection zero_bits parameter semantics

Rémi Bernon rbernon at codeweavers.com
Wed May 29 05:19:23 CDT 2019


On Wed, 2019-05-29 at 11:04 +0100, Huw Davies wrote:
> On Tue, May 28, 2019 at 12:15:17PM +0200, Rémi Bernon wrote:
> > As for NtAllocateVirtualMemory, the parameter was misinterpreted as
> > an
> > alignment value. This wasn't used anywhere, so just add an explicit
> > alignment parameter to internal virtual_map_section function and
> > return an error when zero_bits is used.
> 
> I might be missing something here, but if the non-default alignment
> is not needed, what's the purpose of the helper function?
> 
> Huw.

Well, the helper function was already there, I added an alignment
parameter to avoid further mistakes with zero_bits parameter, but it
isn't really necessary.

Rémi




More information about the wine-devel mailing list