[PATCH v6 1/7] ntdll/tests: Move NtAllocateVirtualMemory tests that were in kernel32

Alexandre Julliard julliard at winehq.org
Fri May 31 04:06:28 CDT 2019


Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Huw Davies <huw at codeweavers.com> wrote:
>
>> On Fri, May 31, 2019 at 10:31:10AM +0200, RĂ©mi Bernon wrote:
>> > Is there a particular reason the tested functions are dynamically
>> > loaded in some test executables?
>> 
>> The typical reason would be that the functions are not available on
>> all of the Windows versions that we test.
>> 
>> As we retire testing on older Windows versions this can leave us
>> dynamically loading functions that we need not any more.
>
> Another reason is that sometimes PSDK doesn't have an appropriate import
> library. Alphough it tends to get added in newer PSDK versions, but that's
> not a good reason to break compilation with older PSDK versions by removing
> dynamic API loading (some people abuse this very badly recently).

It's not unreasonable to require a recent PSDK, if that makes the code
simpler.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list