[PATCH v6 1/7] ntdll/tests: Move NtAllocateVirtualMemory tests that were in kernel32

[Dmitry Timoshkov]

Zebediah Figura <z.figura12 at gmail.com> wrote:

> On 5/31/19 4:17 AM, Dmitry Timoshkov wrote:
> > Alexandre Julliard <julliard at winehq.org> wrote:
> > 
> >> Dmitry Timoshkov <dmitry at baikal.ru> writes:
> >>
> >>> Huw Davies <huw at codeweavers.com> wrote:
> >>>
> >>>> On Fri, May 31, 2019 at 10:31:10AM +0200, Rémi Bernon wrote:
> >>>>> Is there a particular reason the tested functions are dynamically
> >>>>> loaded in some test executables?
> >>>>
> >>>> The typical reason would be that the functions are not available on
> >>>> all of the Windows versions that we test.
> >>>>
> >>>> As we retire testing on older Windows versions this can leave us
> >>>> dynamically loading functions that we need not any more.
> >>>
> >>> Another reason is that sometimes PSDK doesn't have an appropriate import
> >>> library. Alphough it tends to get added in newer PSDK versions, but that's
> >>> not a good reason to break compilation with older PSDK versions by removing
> >>> dynamic API loading (some people abuse this very badly recently).
> >>
> >> It's not unreasonable to require a recent PSDK, if that makes the code
> >> simpler.
> > 
> > Some of my test WMs running Widows XP, some Windows 7, it's pretty questionable
> > to require installing a Windows 10 SDK there (if it will ever install under XP).
> > On the other hand a test compiled under Windows 7 won't run under XP. Personally,
> > I find testing under XP and Windows 7 very valueable, please don't ruin that
> > ability.
> > 
> 
> mingw-w64 works quite well for compiling tests to run under XP.

Probably, but using native tools is always preferrable.

-- 
Dmitry.