[PATCH] ucrtbase: Implement t and j printf length modifiers.

[Ambrož Bizjak]

Updated patch:
- Using if (sizeof(type) == 8) instead of #ifdef _WIN64.
- Using the MIN_/MAX_ constants for the exact type being tested to
prevent a warning.
- Added Signed-off-by line.

On Fri, Nov 1, 2019 at 6:02 PM Piotr Caban <piotr.caban at gmail.com> wrote:
>
> Hi,
>
> Can't PTRDIFF_MIN or PTRDIFF_MAX be used to avoid the warning?
>
> Thanks,
> Piotr
>
> On 11/1/19 5:28 PM, Ambrož Bizjak wrote:
> > Hi,
> > The reason for the define is that I was getting warnings about integer
> > overflow from the branch that is not taken (too large value converted to
> > 32 bits).
> >
> > Let me know if that's ok, then I will resend with signed-off.
> >
> > On Friday, November 1, 2019, Piotr Caban <piotr.caban at gmail.com
> > <mailto:piotr.caban at gmail.com>> wrote:
> >
> >     Hi Ambrož,
> >
> >     The patch looks mostly good to me but it's required that you add
> >     signed-off-by line
> >     (https://wiki.winehq.org/Submitting_Patches#The_commit_message
> >     <https://wiki.winehq.org/Submitting_Patches#The_commit_message>).
> >
> >     What's the reason for changing:
> >     if (sizeof(void*) == 8)
> >     to
> >     #ifdef _WIN64
> >     ?
> >     I think it's better to keep it as is so the code is always compiled.
> >
> >     Thanks,
> >     Piotr
> >
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wine-printf-t-j-formats.patch
Type: text/x-patch
Size: 4054 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20191101/1ea0c61a/attachment.bin>