[PATCH] vkd3d: Fix handling of SM 5.1 register spaces.

Henri Verbeet hverbeet at gmail.com
Mon Nov 4 09:45:33 CST 2019


On Fri, 1 Nov 2019 at 17:08, Hans-Kristian Arntzen
<post at arntzen-software.no> wrote:
>
> The resource index is not found in idx[0], but idx[1] when using SM 5.1,
> and register space information depends on resource type.
>
> Pass down space/index information directly to resource declaration
> functions instead rather than relying on this information being in
> reg.idx[0].
>
> Signed-off-by: Hans-Kristian Arntzen <post at arntzen-software.no>
> ---
>  include/vkd3d_shader.h                   |  3 ++
>  libs/vkd3d-shader/dxbc.c                 | 31 ++++++++++++
>  libs/vkd3d-shader/spirv.c                | 63 ++++++++++++++----------
>  libs/vkd3d-shader/vkd3d_shader_private.h |  5 ++
>  libs/vkd3d/state.c                       | 24 +++++----
>  libs/vkd3d/vkd3d_private.h               |  1 +
>  6 files changed, 87 insertions(+), 40 deletions(-)
>
Hi Hans-Kristian,

This seems to make sense at first sight, but do you also have some
tests to go along with these patches?

As an aside, could you please set the git format-patch subject prefix
(format.subjectprefix) for vkd3d patches to "PATCH vkd3d", so that
these can be properly distinguished from Wine patches?

Henri



More information about the wine-devel mailing list