[PATCH 1/2] msvcrt/tests: Fix 2 MSVC warnings about result.

Piotr Caban piotr.caban at gmail.com
Wed Nov 6 03:56:00 CST 2019


Hi Serge,

This warnings are only displayed when modified scanf test are compiled 
(that link to sscanf directly). I still think there's nothing to fix in 
wine. Also the "%hhd" warning is incorrect unless you're accidentally 
linking to ucrtbase.

Thanks,
Piotr

On 11/5/19 11:18 PM, Serge Gautherie wrote:
> 
> ReactOS, built with MSVC 2019 (I did not test older versions):
> 
> msvc:
> https://ci.appveyor.com/project/SergeGautherie/reactos/builds/28561079/job/79t3g8xq8ebb7ukf?fullLog=true 
> 
> 
> msvc-x64:
> https://ci.appveyor.com/project/SergeGautherie/reactos/builds/28561079/job/ipo4cxb7u8x4bl5x?fullLog=true 
> 
> 
> 
> On 05/11/2019 11:36, Piotr Caban wrote:
> 
>> Hi Serge,
>>
>> On 11/3/19 3:51 AM, Serge Gautherie wrote:
>>> "...\scanf.c(204): warning C4477: 'sscanf' : format string '%hd'
>>> requires an argument of type 'short *', but variadic argument 1 has
>>> type 'int *'"
>>> "...\scanf.c(209): warning C4477: 'sscanf' : format string '%hhd'
>>> requires an argument of type 'signed char *', but variadic argument 1
>>> has type 'int *'"
>> Second warning doesn't have sense for msvcrt. It doesn't support %hhd
>> format. What version of compiler shows these errors? I would expect that
>> format/parameters are not validated when function pointer is used.
>>
>> Thanks,
>> Piotr
> 




More information about the wine-devel mailing list