[PATCH 3/5] jscript: Implement script persistence.

Jacek Caban jacek at codeweavers.com
Wed Nov 6 10:57:43 CST 2019


On 11/6/19 5:50 PM, Jacek Caban wrote:
> Hi Gabriel,
>
> On 11/6/19 4:28 PM, Gabriel Ivăncescu wrote:
>> --- a/dlls/jscript/jscript.c
>> +++ b/dlls/jscript/jscript.c
>> @@ -62,6 +62,8 @@ typedef struct {
>>         bytecode_t *queue_head;
>>       bytecode_t *queue_tail;
>> +    bytecode_t *persistent_head;
>> +    bytecode_t *persistent_tail;
>
>
> I think it would be cleaner to use struct list from wine/list.h instead. 


I replied too soon. It would be generally preferable, more importantly, 
it's the same question as I had for vbscript: why do we need a separated 
list? Can we just store a flag?


Thanks,

Jacek




More information about the wine-devel mailing list