[PATCH v5 4/7] vbscript: Append to the global lists when the code is executed, rather than compiled.

Jacek Caban jacek at codeweavers.com
Thu Nov 7 12:28:40 CST 2019

Hi Gabriel,

On 11/7/19 2:28 PM, Gabriel Ivăncescu wrote:
> diff --git a/dlls/vbscript/vbscript.h b/dlls/vbscript/vbscript.h
> index 04a9b83..efc3585 100644
> --- a/dlls/vbscript/vbscript.h
> +++ b/dlls/vbscript/vbscript.h
> @@ -350,6 +350,9 @@ struct _vbscode_t {
>       unsigned bstr_cnt;
>       heap_pool_t heap;
> +    dynamic_var_t *global_vars;

It seems to me that we don't need it. Now that we post-process variables 
to append to global variable set anyway, we could just get rid of 
special-case for global code in compiler and use variables stored in 
vbscode_t::main_code when we need to add them to global variables set.


More information about the wine-devel mailing list