[PATCH] dsound/tests: Add media object query tests

Andrew Eikum aeikum at codeweavers.com
Thu Nov 7 15:22:07 CST 2019

On Thu, Nov 07, 2019 at 07:28:36PM +0000, Alistair Leslie-Hughes wrote:
> +    rc = IUnknown_QueryInterface(dmo, &IID_IMediaObject, (void**)&inplace);
> > Wrong IID here.
> >
> > Also, these tests seem like implementation details. What's your
> > motivation here? Is there an app that depends on this behavior?
> No app depends on this behavior.
> dsound (builtin) queriesfor these interfaces and I was showing that DMO's support the interfaces 
> and at the same time trying to work out how much of the 
> IMediaObjec/IMediaObjectInPlace code I could share between them
> My current implementation has a complete copy of each these interfaces.
> I'm happy to drop tests and just prove the interfaces exists and we can 
> get back to the object original, if that helps.

Yeah I think the pointer value tests aren't interesting unless an
application needs it.


More information about the wine-devel mailing list