[PATCH] crypt32/tests: Use GetWindowsDirectoryA instead of GetEnvironmentVariableA to avoid a test failure.

Sven Baars sven.wine at gmail.com
Fri Nov 8 16:11:11 CST 2019


On 08-11-19 22:59, Zebediah Figura wrote:
> On 11/8/19 3:54 PM, Sven Baars wrote:
>> Signed-off-by: Sven Baars <sven.wine at gmail.com>
>> ---
>>   dlls/crypt32/tests/sip.c | 9 +++------
>>   1 file changed, 3 insertions(+), 6 deletions(-)
>>
> 
> As far as I see this only happens on Wine, and only on one machine. So
> while this code is simpler and probably more desirable anyway, "to avoid
> a test failure" is probably not a good reason for it.

That's true. Maybe we should just wait for Francois to fix that machine
instead, since it has many unique failures. I was just clicking on
random test failures and not really thinking anymore since it's already
quite late... Sorry for the noise.



More information about the wine-devel mailing list