[PATCH 3/5] wined3d: Fixup alpha component in surface_convert_format().

[Henri Verbeet]

On Fri, 8 Nov 2019 at 15:28, Paul Gofman <gofmanp at gmail.com> wrote:
> @@ -685,14 +762,22 @@ static struct wined3d_texture *surface_convert_format(struct wined3d_texture *sr
>      else
>      {
>          struct wined3d_box src_box = {0, 0, desc.width, desc.height, 0, 1};
> +        struct wined3d_bo_address conv_data;
>
>          TRACE("Using upload conversion.\n");
>
>          wined3d_texture_prepare_location(dst_texture, 0, context, WINED3D_LOCATION_TEXTURE_RGB);
> -        dst_texture->texture_ops->texture_upload_data(context, wined3d_const_bo_address(&src_data),
> +
> +        wined3d_fixup_alpha(context, src_format, dst_format, &src_data, src_row_pitch,
> +                desc.width, desc.height, &conv_data);
> +
Although X-channel data is undefined, it seems undesirable to modify
the source data. Wouldn't it be better to fixup the destination data
instead?