[RFC PATCH 4/6] user32: Remove __wine_send_input function.

Alexandre Julliard julliard at winehq.org
Tue Nov 12 03:04:53 CST 2019

Rémi Bernon <rbernon at codeweavers.com> writes:

> __wine_send_input was introduced at a time when SendInput was handled
> in the graphics drivers, we don't do that anymore and it makes little
> sense to go through user32 for user input now.
> Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
> ---
> Notes:
>     Making the request directly also bypasses the wait for the reply,
>     as well as some state update, but I think it should be alright as
>     we should not care about native vs injected input processing order.
>     I'm not entirely sure of the implication of not waiting for the
>     reply, but I think graphics drivers don't care about it. It also has
>     a beneficial impact on performance in the case where we would have
>     waited for the reply on each input.

The wait is necessary for hook processing. The state update is also
needed to avoid redundant server calls. It doesn't look like this series
is going in the right direction.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list