[PATCH v7 5/7] vbscript: Move the global lists to the script dispatch object.

Jacek Caban jacek at codeweavers.com
Tue Nov 12 14:50:49 CST 2019

On 11/12/19 1:36 PM, Gabriel Ivăncescu wrote:
> On 11/11/19 9:31 PM, Jacek Caban wrote:
>> Hi Gabriel,
>> On 11/11/19 1:34 PM, Gabriel Ivăncescu wrote:
>>> Signed-off-by: Gabriel Ivăncescu<gabrielopcode at gmail.com>
>>> ---
>>> Note that we have to move the non-persistent vbscode from the 
>>> context's list,
>>> so it can be freed by the dispatch object only when it is released.
>>> This will be needed for the TypeInfo and named contexts.
>> The patch looks good, assuming we're really going in the right 
>> direction. I would prefer to review it properly once I can see the 
>> code that needs it.
>> I signed off the rest of the series, because it didn't depend on this 
>> patch. The fact that no test failed without this patch gives you a 
>> nice hint about an interesting test...
>> Thanks,
>> Jacek
> Hi Jacek,
> Yeah this patch doesn't influence existing tests, but it will be 
> needed for TypeInfo and named contexts, where each named item will 
> have its own separate script dispatch (and of course, in *those* 
> tests, it will be required). 

Sure, just please send it together with TypeInfo changes so I can review 
it together.



More information about the wine-devel mailing list