[PATCH] comctl32: Bump version to 6.0.

[Dmitry Timoshkov]

Alexandre Julliard <julliard at winehq.org> wrote:

> >> > > > An application that I have here checks comctl32.dll version information
> >> > > > and refuses to run, changing DLL version to 6.0 makes it run.
> >> > ...
> >> > > So which one does it check, resources or DllGetVersion()?
> >> >
> >> > It checks the version information in the DLL resources
> >> > (GetFileVersionInfo).
> >> >
> >> 
> >> In that case I'd suggest to have it tested in staging first, at least until
> >> next stable release. It's not an ordinary dll version change because it's
> >> up to application to request it.
> >
> > I have another suggestion:
> > We have a rule to revert patches that cause regressions, it would be
> > better IMO to accept this patch in main tree, test it, and if it will
> > cause regressions for a wide range of applications then revert it before
> > the code freeze.
> 
> No, we don't have such a rule; in fact, reverts are strongly
> discouraged.
> 
> If a change to fix app A breaks app B, reverting it to repair app B
> would break app A again. That doesn't get us any closer to our goal of
> supporting both apps, and there's no good way of deciding which of A or
> B is less important and deserves to remain broken.
> 
> So if a change is expected to break something, we should take steps to
> avoid that *before* committing it.

Personaly I don't expect this patch to break something.

-- 
Dmitry.