[PATCH] msvcrt: Provide pow2 implementation in static library for msvcrt versions that don't provide it.

[Jacek Caban]

On 11/13/19 7:52 PM, Alexandre Julliard wrote:
> Jacek Caban <jacek at codeweavers.com> writes:
>
>> BTW, before I wrote this patch, I used CROSSCFLAGS=-fno-builtin-exp2
>> as a workaround (-fno-builtin-pow should do the trick as well), but I
>> don't think we should go in that direction.
> Maybe not, but having to add -fno-builtin in all the msvcrt makefiles
> doesn't seem that much better.


Yeah, that's not pretty. Maybe we could just apply -fno-builtin to all 
files with "makedep implib" pragma.


Long term I think we want an actual exp2 implementation inside static 
lib for msvcrt versions that don't export it from DLL. From what I heard 
from Piotr, the plan is to import math functions from some libc 
implementation and have them built inside msvcrt. Once we have that, it 
should be straightforward to add that to static libs as well. We may 
require additional CROSSCFLAGS meantime.


Thanks,

Jacek