[PATCH v2 2/4] dmstyle: Free list when Style track is destroyed
Michael Stefaniuc
mstefani at winehq.org
Thu Nov 14 13:40:25 CST 2019
From: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
---
v2: Avoid LPJUNK style types
dlls/dmstyle/styletrack.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/dlls/dmstyle/styletrack.c b/dlls/dmstyle/styletrack.c
index 496e0c5ba7..cc15bd81d1 100644
--- a/dlls/dmstyle/styletrack.c
+++ b/dlls/dmstyle/styletrack.c
@@ -20,6 +20,8 @@
#include "dmstyle_private.h"
#include "dmobject.h"
+#include "wine/heap.h"
+
WINE_DEFAULT_DEBUG_CHANNEL(dmstyle);
WINE_DECLARE_DEBUG_CHANNEL(dmfile);
@@ -80,7 +82,18 @@ static ULONG WINAPI style_track_Release(IDirectMusicTrack8 *iface)
TRACE("(%p) ref=%d\n", This, ref);
if (!ref) {
- HeapFree(GetProcessHeap(), 0, This);
+ struct list *cursor, *cursor2;
+ DMUS_PRIVATE_STYLE_ITEM *item;
+
+ LIST_FOR_EACH_SAFE(cursor, cursor2, &This->Items) {
+ item = LIST_ENTRY(cursor, DMUS_PRIVATE_STYLE_ITEM, entry);
+ list_remove(cursor);
+
+ IDirectMusicStyle8_Release(item->pObject);
+ heap_free(item);
+ }
+
+ heap_free(This);
DMSTYLE_UnlockModule();
}
--
2.20.1
More information about the wine-devel
mailing list