[PATCH vkd3d 2/2] vkd3d: Return valid node masks in external resource heap properties.

Henri Verbeet hverbeet at gmail.com
Mon Nov 18 03:31:00 CST 2019


On Mon, 18 Nov 2019 at 07:01, Conor McCarthy <cmccarthy at codeweavers.com> wrote:
> November 16, 2019 4:47 AM, "Henri Verbeet" <hverbeet at gmail.com> wrote:
> > It should be trivial to write a corresponding test for this, correct?
>
> They should already be in your assigned patches:
> https://source.winehq.org/patches/data/173675
>
> The tests are best done in Wine, where the swapchain and buffers are created.

That's doesn't work for the purposes of a vkd3d regression test; vkd3d
can't depend on the tests for any particular external user of vkd3d
being run before each commit is pushed. Having the d3d12 test is fine,
but it serves a different purpose than a vkd3d test would.



More information about the wine-devel mailing list