[PATCH v7 3/3] kernel32: Make GetUserGeoID() pretend we set a GeoID even if we didn't.

João Diogo Ferreira devilj at outlook.pt
Mon Nov 18 06:14:05 CST 2019


A segunda-feira, 18 de novembro de 2019 11:12:51 WET Alexandre Julliard escreveu:
> > For Wine, this fixes an edge-case scenario where we would autodetect a
> > region-class ID from a locale, leaving the nation class empty.
> > As most apps only care about nations, this would make some apps crash
> > regardless of our autodetection mechanism.
> 
> Is there any locale where this would happen?

Yes, file enb.nls for «English (Caribbean)» has the ID "161832257";
that's the Caribbean region.
I don't know if it maps to any Linux locale and can be used, though,
so it might not even be a problem (for now).

> If so, shouldn't
> SetUserGeoID set a default Nation key?  Otherwise if it's really
> supposed to be unset, it would have to unset it explicitly. Same for the
> Region key of course.

Yes, that's another way to fix it. Probably have it fall back to the US
since that's the default in Linux when we don't get a locale.





More information about the wine-devel mailing list