[PATCH 4/9] d3dx9/tests: Test ApplyParameterBlock() while recording.

Matteo Bruni matteo.mystral at gmail.com
Mon Nov 18 10:24:51 CST 2019

On Mon, Nov 18, 2019 at 5:13 PM Paul Gofman <gofmanp at gmail.com> wrote:
> On 11/18/19 18:59, Matteo Bruni wrote:
> > Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
> > ---
> > While reviewing the previous patch I became curious WRT
> > ApplyParameterBlock() while recording another parameter block. I
> > didn't notice your test in patch 9/9 at the time (a point to having
> > the test earlier in the series, probably) so I wrote my own
> > version. Good thing that I did: it looks like applying a parameter
> > block while recording also doesn't update the effect parameters.
> >
> Oh yeah, it looks like it doesn't. My test was zeroing values before
> 'ApplyParameterBlock' to test that, but was doing that while recording
> of a new block was already active, so the parameter value was not
> actually cleared before apply test.

Yeah, with the above I meant that it was a bit of a fortunate mistake
that I didn't notice your test and ended up rewriting it, because
probably I'd have overlooked that detail too otherwise.

More information about the wine-devel mailing list