[PATCH v2 3/5] msvcrt: Correct behavior of strftime formats %c %x.

Jeff Smith whydoubt at gmail.com
Wed Nov 20 08:09:40 CST 2019


Hi Piotr,

Sounds good, and I will take a good look at it shortly.
BTW, great work hooking into _Strftime to test these!
It definitely exposed those aspects that differ from
GetTimeFormat/GetDateFormat even more than I had determined.
It is interesting that there seems to be no way to have a single-quote
in the final string, and even the single-quote in the format string
doesn't work as expected in some versions of ucrtbase.dll.

Thanks,
Jeff

On Wed, Nov 20, 2019 at 6:21 AM Piotr Caban <piotr.caban at gmail.com> wrote:
>
> Hi Jeff,
>
> I've sent patches that are adding more tests for these formats. I've
> also changed this patch and sent it as part of the serie. I didn't
> change patch 4/5 - it will need to be reworked in similar way as this
> patch to pass the tests.
>
> The tests also show that there's something wrong with patch 5/5. I
> didn't dig into it.
>
> Thanks,
> Piotr



More information about the wine-devel mailing list