[PATCH] gdi32/tests: Reserve sufficient room for DIB data.

Dmitry Timoshkov dmitry at baikal.ru
Fri Nov 22 00:49:17 CST 2019


Jeff Smith <whydoubt at gmail.com> wrote:

> +#define DATA_WIDTH 2
> +#define DATA_HEIGHT 2
> +#define MAX_PLANES 64
> +#define MAX_BPP 64
> +
>  static void test_dib_formats(void)
>  {
>      BITMAPINFO *bi;
> -    char data[256];
> +    char data[((DATA_WIDTH * MAX_BPP + 31) / 32) * 4 * DATA_HEIGHT * MAX_PLANES];

This makes the test absolutely unreadable. Just adding a comment around
char data[2544]; /* enough to hold DIB test data */
would be enough IMO.

-- 
Dmitry.



More information about the wine-devel mailing list