[PATCH] urlmon/tests: Don't perform extra uri tests if a failure was expected.

Jacek Caban jacek at codeweavers.com
Fri Nov 22 05:54:39 CST 2019


Hi Francois,

On 11/21/19 5:12 PM, Francois Gouget wrote:
> --- a/dlls/urlmon/tests/uri.c
> +++ b/dlls/urlmon/tests/uri.c
> @@ -10587,7 +10587,7 @@ static void test_CoInternetCombineIUri(void) {
>                       ok(hr == uri_combine_tests[i].expected,
>                           "Error: CoInternetCombineIUri returned 0x%08x, expected 0x%08x on uri_combine_tests[%d].\n",
>                           hr, uri_combine_tests[i]. expected, i);
> -                if(SUCCEEDED(hr)) {
> +                if(SUCCEEDED(hr) && uri_combine_tests[i].expected) {


Note that 'expected' us a HRESULT, so in this case you check if it's not 
S_OK. I will send a fixed version.


Thanks,

Jacek




More information about the wine-devel mailing list