[PATCH] user32/test: Start the AdjustWindowRectExForDpi() from a known state.
Francois Gouget
fgouget at free.fr
Fri Nov 22 06:07:20 CST 2019
On Thu, 21 Nov 2019, Marvin wrote:
[...]
> === w1064v1809 (32 bit report) ===
> === w1064v1809_2scr (32 bit report) ===
> === w1064v1809_ar (32 bit report) ===
> === w1064v1809_he (32 bit report) ===
> === w1064v1809_ja (32 bit report) ===
> === w1064v1809_zh_CN (32 bit report) ===
> === w1064v1809 (64 bit report) ===
>
> user32:
> win.c:3176: Test failed: GetActiveWindow() = 0004004A
> win.c:3179: Test failed: GetFocus() = 00000000
> win.c:3182: Test failed: SetActiveWindow returned 00000000 instead of 0004004A
> win.c:3189: Test failed: GetFocus() = 00000000
> win.c:3192: Test failed: GetFocus() = 00000000
> win.c:3195: Test failed: GetFocus() = 00000000
> win.c:3198: Test failed: GetActiveWindow() = 0004004A
> win.c:3202: Test failed: GetFocus() = 00000000
> win.c:3205: Test failed: GetFocus() = 00000000
> win.c:3240: Test failed: expected 0004004A, got 00000000
> win.c:3892: Test failed: hwnd 000300E0/000B02E2 message 0737
> win.c:3897: Test failed: hwnd 000B02E2/000B02E2 message 0202
> win.c:3902: Test failed: hwnd 000B02E2/000B02E2 message 0203
> win.c:3906: Test failed: message 0202 available
> win.c:3994: Test failed: hwnd 000A0044/000A0044 message 00a1
[...]
These are all preexisting failures.
- First they happen in code run before the part touched by this patch.
- Second they happen for a dummy patch too:
https://testbot.winehq.org/JobDetails.pl?Key=60653#k202
But the strange thing is that most of these errors don't happen in the
WineTest runs. :
https://test.winehq.org/data/288a6625ad0177e258a0db1da166d292ff420b1e/index_Win10.html#user32:win
- And of course the window handles are likely to change with every run,
thus preventing the TestBot from knowing whether these are new
failures or not. In particular this appears to be what happened to the
following failure:
win.c:3240: Test failed: expected 0004004A, got 00000000
vs. the WineTest version:
win.c:3240: Test failed: expected 00670480, got 00000000
> win.c:5414: Test failed: 00c00000 00000000 rects do not match: win (97,52)-(203,203) wine (97,74)-(203,203)
> win.c:5414: Test failed: 00c00000 00000200 rects do not match: win (95,50)-(205,205) wine (95,72)-(205,205)
These are the ones that are impacted by the rect change. So these will
appear as new since the coordinates changed a bit.
--
Francois Gouget <fgouget at free.fr> http://fgouget.free.fr/
Stolen from an Internet user:
"f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"
More information about the wine-devel
mailing list