[PATCH 6/7] msvcrt: Call invalid parameter handler for out-of-range integer.

Piotr Caban piotr.caban at gmail.com
Fri Nov 22 06:54:32 CST 2019


On 11/22/19 1:35 PM, Piotr Caban wrote:
> Hi Jeff,
> 
> On 11/22/19 1:28 AM, Jeff Smith wrote:
>>       if(src<l || src>h) {
>>           *str = 0;
>> -        *MSVCRT__errno() = MSVCRT_EINVAL;
>> +        MSVCRT_INVALID_PMT("Invalid value", MSVCRT_EINVAL);
>>           return FALSE;
>>       }
> Please change it to if(!MSVCRT_CHECK_PMT(src>=l && src<=h)).
> 
> Could you please also move it earlier in the series? It makes some other 
> changes not needed (e.g. patch 5/7 is not needed).
The patch 5/7 will still be needed, sorry for that. Please only change 
the if condition.

Thanks,
Piotr



More information about the wine-devel mailing list