[PATCH] gdi32/tests: CloseMetaFile() no longer destroys the metafile hdc.

Francois Gouget fgouget at free.fr
Wed Nov 27 15:35:36 CST 2019


On Mon, 25 Nov 2019, Huw Davies wrote:

> On Thu, Nov 21, 2019 at 04:08:46PM +0100, Francois Gouget wrote:
> > Windows 10 1507 still deleted it but 1607 no longer does.
> > 
> > Signed-off-by: Francois Gouget <fgouget at free.fr>
> > ---
> > 
> > Even calling GetObjectType() after calling DeleteMetaFile() still 
> > returns OBJ_METADC so I don't know when Windows actually destroys the 
> > metafile hdc. Maybe it does destroy it but GetObjectType() does not 
> > notice until the corresponding memory area is reused for something else?
> > 
> > From time to time there is a run with only two failures which I 
> > think gives credit to the above theory:
> > https://test.winehq.org/data/aa3d01e65019fb2f135f74cf26cfa1661ca09325/index_Win10.html#kernel32:codepage
> > 
> > In any case this behavior seems broken so I'm marking it as such in the 
> > test.
> 
> How about using something similar to:
> 9cffe80fdc gdi32/tests: Fix a test failure on Win10 1809. ?

GetDeviceCaps() still returns DT_METAFILE after CloseMetaFile(). What's 
worse is it does that even on Windows 2003 which probably means most 
Windows versions.

https://testbot.winehq.org/JobDetails.pl?Key=60980&f201=exe32.report


-- 
Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
                            $live{free} || die "";



More information about the wine-devel mailing list