[PATCH v3] gdi32/tests: MoveToEx() does not return the old point.

Huw Davies huw at codeweavers.com
Thu Nov 28 06:34:37 CST 2019


On Thu, Nov 28, 2019 at 01:08:34PM +0100, Francois Gouget wrote:
> This behavior goes back to at least Windows XP.
> But Wine depends on MoveToEx() returning the old point and changing Wine
> does not seem necessary. So expect the documented behavior and mark the
> current Windows behavior as broken.
> 
> Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> ---
> 
> v3: Accept the documented behavior. Wine no longer needs a todo.
>     Better document the Windows behavior.
> 
>  dlls/gdi32/painting.c       |  3 +++
>  dlls/gdi32/tests/metafile.c | 16 ++++++++--------
>  2 files changed, 11 insertions(+), 8 deletions(-)
> 
> diff --git a/dlls/gdi32/painting.c b/dlls/gdi32/painting.c
> index 81937b8bbb4..f0aee5b8d8c 100644
> --- a/dlls/gdi32/painting.c
> +++ b/dlls/gdi32/painting.c
> @@ -257,6 +257,9 @@ BOOL WINAPI LineTo( HDC hdc, INT x, INT y )
>  
>  /***********************************************************************
>   *           MoveToEx    (GDI32.@)
> + *
> + * Wine returns the previous position in pt as per the documentation.
> + * However note that no Windows version does since at least XP.
>   */

I'm pretty sure Windows does return the previous position on dcs that
aren't metafile dcs, so this really doesn't belong here.

Huw.



More information about the wine-devel mailing list