[PATCH v2 2/6] wined3d: Introduce wined3d_stateblock_get_state().
z.figura12 at gmail.com
Fri Nov 29 09:16:33 CST 2019
On 11/29/19 1:25 AM, Henri Verbeet wrote:
> On Thu, 28 Nov 2019 at 09:24, Zebediah Figura <z.figura12 at gmail.com> wrote:
>> +#define LIGHTMAP_SIZE 43
>> +#define LIGHTMAP_HASHFUNC(x) ((x) % LIGHTMAP_SIZE)
> Although wined3d is an internal Wine interface, it still seems
> unfortunate to expose this particular implementation detail in the
> public wined3d interface.
Understandable, though I'm not immediately sure what do about it.
We could introduce individual wined3d_stateblock_get_*() helpers, though
at the last point of conversation regarding stateblocks, I recall you
seemed to prefer allowing direct access to struct wined3d_stateblock_state.
I guess another option is to hold a pointer to wined3d_light_state
instead of exposing it directly.
More information about the wine-devel