[PATCH v3] x3daudio: fix lib exports

Alexandre Julliard julliard at winehq.org
Tue Oct 1 15:40:55 CDT 2019


Nikolay Sivov <nsivov at codeweavers.com> writes:

> On 10/1/19 10:19 PM, Andrew Eikum wrote:
>
>> On Mon, Sep 30, 2019 at 11:34:34PM +0200, Rafał Mużyło wrote:
>>> --- a/dlls/x3daudio1_0/x3daudio1_0.spec	2019-08-30 22:11:51.000000000 +0200
>>> +++ b/dlls/x3daudio1_0/x3daudio1_0.spec	2019-09-24 13:02:59.151295631 +0200
>>> @@ -1,2 +1,4 @@
>>> -@ cdecl X3DAudioCalculate(ptr ptr ptr long ptr)
>>> -@ cdecl X3DAudioInitialize(long float ptr) LEGACY_X3DAudioInitialize
>>> +@ stdcall -arch=win32 _X3DAudioCalculate at 20(ptr ptr ptr long ptr) LEGACY_X3DAudioCalculate
>>> +@ stdcall -arch=win32 _X3DAudioInitialize at 12(long float ptr) LEGACY_X3DAudioInitialize
>>> +@ stdcall -arch=win64 X3DAudioCalculate(ptr ptr ptr long ptr) LEGACY_X3DAudioCalculate
>>> +@ stdcall -arch=win64 X3DAudioInitialize(long float ptr) LEGACY_X3DAudioInitialize
>>> --- a/dlls/x3daudio1_1/x3daudio1_1.spec	2019-08-30 22:11:51.000000000 +0200
>>> +++ b/dlls/x3daudio1_1/x3daudio1_1.spec	2019-09-24 13:02:59.151295631 +0200
>>> @@ -1,2 +1,4 @@
>>> -@ cdecl X3DAudioCalculate(ptr ptr ptr long ptr)
>>> -@ cdecl X3DAudioInitialize(long float ptr) LEGACY_X3DAudioInitialize
>>> +@ stdcall -arch=win32 _X3DAudioCalculate at 20(ptr ptr ptr long ptr) LEGACY_X3DAudioCalculate
>>> +@ stdcall -arch=win32 _X3DAudioInitialize at 12(long float ptr) LEGACY_X3DAudioInitialize
>>> +@ stdcall -arch=win64 X3DAudioCalculate(ptr ptr ptr long ptr) LEGACY_X3DAudioCalculate
>>> +@ stdcall -arch=win64 X3DAudioInitialize(long float ptr) LEGACY_X3DAudioInitialize
>>> --- a/dlls/x3daudio1_2/x3daudio1_2.spec	2019-08-30 22:11:51.000000000 +0200
>>> +++ b/dlls/x3daudio1_2/x3daudio1_2.spec	2019-09-24 13:02:59.151295631 +0200
>>> @@ -1,2 +1,4 @@
>>> -@ cdecl X3DAudioCalculate(ptr ptr ptr long ptr)
>>> -@ cdecl X3DAudioInitialize(long float ptr) LEGACY_X3DAudioInitialize
>>> +@ stdcall -arch=win32 _X3DAudioCalculate at 20(ptr ptr ptr long ptr) LEGACY_X3DAudioCalculate
>>> +@ stdcall -arch=win32 _X3DAudioInitialize at 12(long float ptr) LEGACY_X3DAudioInitialize
>>> +@ stdcall -arch=win64 X3DAudioCalculate(ptr ptr ptr long ptr) LEGACY_X3DAudioCalculate
>>> +@ stdcall -arch=win64 X3DAudioInitialize(long float ptr) LEGACY_X3DAudioInitialize
>> I'm not the right person to review this part. Does it look OK to you,
>> Nikolay?
>
> Looks ok, for x86 case. I don't have arm setup to see if has to be
> adjusted there.

There's no stdcall name mangling on ARM, that's x86 only.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list