[PATCH v3 4/4] server: Don't block ConnectNamedPipe for pipe in PIPE_NOWAIT mode.
Brendan Shanks
bshanks at codeweavers.com
Thu Oct 3 14:57:22 CDT 2019
Signed-off-by: Brendan Shanks <bshanks at codeweavers.com>
---
dlls/kernel32/tests/pipe.c | 4 ++--
server/named_pipe.c | 6 ++++++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/dlls/kernel32/tests/pipe.c b/dlls/kernel32/tests/pipe.c
index 46b9e1c667..f53a59db14 100644
--- a/dlls/kernel32/tests/pipe.c
+++ b/dlls/kernel32/tests/pipe.c
@@ -4026,7 +4026,7 @@ static void test_nowait(void)
ol.hEvent = CreateEventW(NULL, TRUE, FALSE, NULL);
SetLastError(0xdeadbeef);
ok(ConnectNamedPipe(pipewrite, &ol) == FALSE, "ConnectNamedPipe should fail\n");
- todo_wine ok(GetLastError() == ERROR_PIPE_LISTENING, "got %d should be ERROR_PIPE_LISTENING\n", GetLastError());
+ ok(GetLastError() == ERROR_PIPE_LISTENING, "got %d should be ERROR_PIPE_LISTENING\n", GetLastError());
if (GetLastError() == ERROR_IO_PENDING)
CancelIo(pipewrite);
@@ -4044,7 +4044,7 @@ static void test_nowait(void)
ok(DisconnectNamedPipe(pipewrite) == TRUE, "DisconnectNamedPipe should succeed\n");
SetLastError(0xdeadbeef);
ok(ConnectNamedPipe(pipewrite,&ol) == FALSE, "ConnectNamedPipe should fail\n");
- todo_wine ok(GetLastError() == ERROR_PIPE_LISTENING, "got %d should be ERROR_PIPE_LISTENING\n", GetLastError());
+ ok(GetLastError() == ERROR_PIPE_LISTENING, "got %d should be ERROR_PIPE_LISTENING\n", GetLastError());
if (GetLastError() == ERROR_IO_PENDING)
CancelIo(pipewrite);
ok(CloseHandle(ol.hEvent), "CloseHandle for the event failed\n");
diff --git a/server/named_pipe.c b/server/named_pipe.c
index 3db8f778a5..7dfd586a30 100644
--- a/server/named_pipe.c
+++ b/server/named_pipe.c
@@ -1108,6 +1108,12 @@ static int pipe_server_ioctl( struct fd *fd, ioctl_code_t code, struct async *as
return 0;
}
+ if (server->pipe_end.flags & NAMED_PIPE_NONBLOCKING_MODE)
+ {
+ set_error( STATUS_PIPE_LISTENING );
+ return 0;
+ }
+
queue_async( &server->listen_q, async );
async_wake_up( &server->pipe_end.pipe->waiters, STATUS_SUCCESS );
set_error( STATUS_PENDING );
--
2.17.1
More information about the wine-devel
mailing list