[PATCH] msxml3/tests: Add IXMLDOMNode::selectSingleNode() test for an XML with multiple namespaces.
Nikolay Sivov
nsivov at codeweavers.com
Wed Oct 9 03:39:36 CDT 2019
On 10/9/19 11:18 AM, Dmitry Timoshkov wrote:
> Nikolay Sivov <nsivov at codeweavers.com> wrote:
>
>> Please use existing function for this.
> I considered that, however existing test_selectSingleNode() is cluttered
> by failure cases, and finally doesn't test anything useful. Using it as
> a place for new tests would add even more mess. I'd prefer to make new tests
> for multiple namespaces a separate test, which could be extended with new
> tests if needed.
Just append it there, and remove whatever you think is broken with
existing tests. Having separate functions for every occasion is worse.
More information about the wine-devel
mailing list