[PATCH] winex11: Initialize biCompression in create_icon_pixmaps (Valgrind)
Alex Henrie
alexhenrie24 at gmail.com
Tue Oct 15 12:49:09 CDT 2019
On Tue, Oct 15, 2019 at 9:26 AM Alexandre Julliard <julliard at winehq.org> wrote:
>
> Alex Henrie <alexhenrie24 at gmail.com> writes:
>
> > create_icon_pixmaps calls GetDIBits, which checks biCompression and
> > returns early if the value is incorrect.
>
> No, the code may not be obvious, but it does the right thing.
You're right, create_icon_pixmaps calls GetDIBits with bits set to
NULL, so biCompression is never checked. Thanks for noticing that.
Sadly it means that something even more obscure is causing the
Valgrind warnings :-(
-Alex
More information about the wine-devel
mailing list