[PATCH] msvcrt: Fix fscanf return when EOF is immediately after an end of line.

Piotr Caban piotr.caban at gmail.com
Thu Oct 17 06:22:00 CDT 2019


Hi Erich,

The implementation part of the patch doesn't look right. I think that it 
should be fixed by %s format reporting error when there's no characters 
to read.

I'm attaching a diff (generated on top of your patch) that shows the 
problems.

Also please use only tests on strings (sscanf) or handle file creation 
failure.

Thanks,
Piotr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tests.diff
Type: text/x-patch
Size: 1021 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20191017/46b4554c/attachment.bin>


More information about the wine-devel mailing list