[PATCH] msvcrt: Fix fscanf return when EOF is immediately after an end of line.

Erich E. Hoover erich.e.hoover at gmail.com
Thu Oct 17 10:41:32 CDT 2019


Thanks Piotr!

I'm happy to change that, I was just using the fprintf tests as a
template.  Does the attached look better to you?

Best,
Erich

On Thu, Oct 17, 2019 at 5:23 AM Piotr Caban <piotr.caban at gmail.com> wrote:
>
> Hi Erich,
>
> The implementation part of the patch doesn't look right. I think that it
> should be fixed by %s format reporting error when there's no characters
> to read.
>
> I'm attaching a diff (generated on top of your patch) that shows the
> problems.
>
> Also please use only tests on strings (sscanf) or handle file creation
> failure.
>
> Thanks,
> Piotr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-msvcrt-Fix-fscanf-return-when-an-empty-string-preced.patch
Type: text/x-patch
Size: 2977 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20191017/532321ef/attachment.bin>


More information about the wine-devel mailing list