[PATCH] mmdevapi/tests: remove todo in traces for capture tests

Sven Baars sven.wine at gmail.com
Fri Oct 18 17:03:24 CDT 2019


On 18-10-19 14:08, Francois Gouget wrote:
> On Fri, 18 Oct 2019, Vijay Kiran Kamuju wrote:
> [...]
>> diff --git a/dlls/mmdevapi/tests/capture.c b/dlls/mmdevapi/tests/capture.c
>> index 0fa9f0cab83..c6142fc4360 100644
>> --- a/dlls/mmdevapi/tests/capture.c
>> +++ b/dlls/mmdevapi/tests/capture.c
>> @@ -392,7 +392,7 @@ static void test_capture(IAudioClient *ac, HANDLE handle, WAVEFORMATEX *wfx)
>>      if(hr == S_OK){
>>          /* Only PulseAudio goes here; despite snd_pcm_drop it manages
>>           * to fill GetBufferSize with a single snd_pcm_read */
>> -        trace("Test marked todo: only PulseAudio gets here\n");
>> +        trace("only PulseAudio gets here\n");
> 
> Do you know why Windows gets there too?
> 
> I also can't find any test results where Wine actually follows this path
(so does PulseAudio really get here?). On the other hand, on one of the
Windows 8 machines for instance, this path actually gives rise to a test
failure:

https://test.winehq.org/data/8c74027ba60a360f24cf232ee233e71262d8f1ff/win8_newtb-w864-32/mmdevapi:capture.html

Note that this is the only failure left on that machine, so fixing it
would mean green tests!

Best,
Sven



More information about the wine-devel mailing list