[PATCH 2/2] psapi/tests: Remove an unreliable test.
Zebediah Figura
z.figura12 at gmail.com
Sat Oct 19 14:39:59 CDT 2019
This fails on Windows 10 version 1709 and later.
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
Evidently locked pages simply aren't reported by
QueryWorkingSet(). Manual testing shows that the allocated page is
reported if *not* locked, and also that it is reported by
QueryWorkingSetEx() in either case. It's not clear if this is a
regression in Windows or an intentional change in behaviour.
dlls/psapi/tests/psapi_main.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/dlls/psapi/tests/psapi_main.c b/dlls/psapi/tests/psapi_main.c
index 78aac2c044..b02ceed5ec 100644
--- a/dlls/psapi/tests/psapi_main.c
+++ b/dlls/psapi/tests/psapi_main.c
@@ -724,7 +724,6 @@ static void test_GetModuleBaseName(void)
static void test_ws_functions(void)
{
PSAPI_WS_WATCH_INFORMATION wswi[4096];
- ULONG_PTR pages[4096];
HANDLE ws_handle;
char *addr;
unsigned int i;
@@ -773,22 +772,6 @@ static void test_ws_functions(void)
goto free_page;
}
- SetLastError(0xdeadbeef);
- ret = QueryWorkingSet(hpQI, pages, 4096 * sizeof(ULONG_PTR));
- todo_wine ok(ret == 1, "failed with %d\n", GetLastError());
- if(ret == 1)
- {
- for(i = 0; i < pages[0]; i++)
- if((pages[i+1] & ~0xfffL) == (ULONG_PTR)addr)
- {
- todo_wine ok(ret == 1, "QueryWorkingSet found our page\n");
- goto test_gwsc;
- }
-
- todo_wine ok(0, "QueryWorkingSet didn't find our page\n");
- }
-
-test_gwsc:
SetLastError(0xdeadbeef);
ret = GetWsChanges(hpQI, wswi, sizeof(wswi));
todo_wine ok(ret == 1, "failed with %d\n", GetLastError());
--
2.20.1
More information about the wine-devel
mailing list