[PATCH] msvcrt: Fix fscanf return when EOF is immediately after an end of line.

[Francois Gouget]

On Mon, 21 Oct 2019, Erich E. Hoover wrote:

> On Mon, Oct 21, 2019 at 10:29 AM Francois Gouget
> <fgouget at codeweavers.com> wrote:
> > On Mon, 21 Oct 2019, Marvin wrote:
> > > ...
> > > https://testbot.winehq.org/JobDetails.pl?Key=58117
> >
> > The reason for these errors is that Windows fails to start the
> > executable because it cannot find microsoft.vc80.crt.
> > ...
> 
> So, what you're saying is that the reason we don't have tests before
> msvcr90 is that not all the testbots can run them.  That makes sense,
> thanks!

Yes, it's possible some VMs are missing some dlls.

Question:
  Do we want some test configurations where these optional components 
  are not installed?


In this case the description for w2008s64 says:

  Upgraded with Internet Explorer 9, .Net Framework 3.5 SP1 & 4.5.1 and 
  all updates up to 2013/04/15. Added Visual C++ 2012 & 2013 runtimes.

Whereas the one for w2003std says:

  Installed Internet Explorer 8, SP2 and all updates up to 2019/07/23. 
  Added .Net 2.0 SP1, 3.0 SP2, 3.5 SP2 & 4, msxml4 SP3, Visual C++ 2005 
  SP1, 2008 SP1 & 2010 SP1 runtimes.

msvcr80 is part of Visual C++ 2005 so it should be present on w2003std. 

For w2008s64 I think I determined that the Visual C++ 2005 runtime was 
already installed and thus did not manually install it. In 
c:\windows\winsxs I do see the following files:

01/19/2008  05:11 AM    <DIR>          amd64_microsoft.vc80.crt_1fc8b3b9a1e18e3b_8.0.50727.1434_none_88de292b2fb06019
04/08/2013  06:58 AM    <DIR>          amd64_microsoft.vc80.crt_1fc8b3b9a1e18e3b_8.0.50727.3053_none_88e044e32fae7230
04/08/2013  07:50 AM    <DIR>          amd64_microsoft.vc80.crt_1fc8b3b9a1e18e3b_8.0.50727.4016_none_88dc01492fb256de
04/08/2013  07:03 AM    <DIR>          amd64_microsoft.vc90.crt_1fc8b3b9a1e18e3b_9.0.21022.8_none_750b37ff97f4f68b
01/19/2008  05:11 AM    <DIR>          x86_microsoft.vc80.crt_1fc8b3b9a1e18e3b_8.0.50727.1434_none_d08b6002442c891f
04/08/2013  06:58 AM    <DIR>          x86_microsoft.vc80.crt_1fc8b3b9a1e18e3b_8.0.50727.3053_none_d08d7bba442a9b36
04/08/2013  07:50 AM    <DIR>          x86_microsoft.vc80.crt_1fc8b3b9a1e18e3b_8.0.50727.4016_none_d0893820442e7fe4
04/08/2013  07:02 AM    <DIR>          x86_microsoft.vc90.crt_1fc8b3b9a1e18e3b_9.0.21022.8_none_bcb86ed6ac711f91

But they are all slightly older than the version required by the patch 
(8.0.50727.4053).


-- 
Francois Gouget <fgouget at codeweavers.com>