[PATCH v3 5/6] setupapi: Implement SetupAddSectionToDiskSpaceList.

[Vijay Kiran Kamuju]

On Mon, Oct 21, 2019 at 9:51 PM Michael Stefaniuc <mstefani at winehq.org> wrote:
>
> On 10/21/19 12:05 AM, Vijay Kiran Kamuju wrote:
> > On Sun, Oct 20, 2019 at 11:38 PM Michael Stefaniuc <mstefani at winehq.org> wrote:
> >>
> >> On 10/20/19 11:00 PM, Vijay Kiran Kamuju wrote:
> >>> +static BOOL get_size_from_inf(HINF layoutinf, WCHAR *filename, LONGLONG *size)
> >>> +{
> >>> +    static const WCHAR SourceDisksFiles[]  = {'S','o','u','r','c','e','D','i','s','k','s','F','i','l','e','s',0};
> >> Should you have to resend for an other reason then please use wide char
> >> string literals in setupapi.
> > The string is same as in queue.c lines 292-293. And in most of the
> > places, its in similar fashion.
> > Did anything change in between on how to represent wide char string literals.
> Yeah, the move to building the DLLs as PE makes it possible to use wide
> char string literals.
> Those are the modules with "EXTRADLLFLAGS = -mno-cygwin" in Makefile.in.
>
> L"SourceDisksFiles", also without a variable to hold it, is so much
> nicer to use.
>
> But like I said, don't worry about it if you don't have to resend.
I will have to resend, thanks for explaining the reason.
If the earlier patches get in, I will send the fixed one later.
Otherwise will resend the patch series tomorrow, I have already made
the changes.
>
Thanks,
Vijay