[PATCH 1/4] xinput: Make device hotplugging thread-safe

Francois Gouget fgouget at codeweavers.com
Tue Oct 22 23:16:37 CDT 2019


On Tue, 22 Oct 2019, Marvin wrote:
[...]
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=58240
[...]
> === debian10 (build log) ===
> 
> error: patch failed: dlls/xinput1_3/hid.c:47
> error: patch failed: dlls/xinput1_3/xinput_main.c:34
> error: patch failed: dlls/xinput1_3/xinput_private.h:19
> Task: Patch failed to apply

In case anyone is wondering what happened here, the reason why it did 
not apply is that by the time the TestBot got around to running this job 
this patchset had been committed and pushed:

 * 15:00:26 -0500 Alexandre receives the patch (based on AuthorDate)
 * 15:05:09 -0500 The TestBot receives the patch
 * 16:04:27 -0500 Alexandre commits the patch
 * 16:59:53 -0500? Alexandre pushes the commits to winehq
 * 18:07:20 -0500 The TestBot updates its Wine source
 * 19:27:58 -0500 The TestBot tries to apply the patch on top of the new 
                  Wine source

So why did it take so long for the TestBot to start testing this patch?

At the time it was busy testing the kernel32 patch series where 8 
patches required a long compilation (rougly 14 minutes for each of the 3 
builds, the joys of modify global headers).


-- 
Francois Gouget <fgouget at codeweavers.com>



More information about the wine-devel mailing list