[PATCH] Revert "ntdll: Skip dlls of the wrong machine type when searching through the load path."

Brendan Shanks bshanks at codeweavers.com
Thu Oct 24 14:17:47 CDT 2019


> On Oct 23, 2019, at 12:57 PM, Alexandre Julliard <julliard at winehq.org> wrote:
> 
> Brendan Shanks <bshanks at codeweavers.com> writes:
> 
>> This reverts commit 9839bb7691a1b1c57a4ca501d03825420c1609d7.
>> Windows 7/2008R2 and up are able to load system DLLs with WoW64
>> redirection disabled, and badly-written installers crash without this.
>> 
>> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47912
>> Signed-off-by: Brendan Shanks <bshanks at codeweavers.com>
>> ---
>> dlls/kernel32/tests/loader.c |  4 ++--
>> dlls/ntdll/loader.c          | 31 +++++++++++--------------------
>> 2 files changed, 13 insertions(+), 22 deletions(-)
> 
> That's going to reintroduce the problems that were fixed by that commit,
> it's not a step forward. If the fix was incomplete it should be
> improved, not reverted.

Yes you’re right, I worked on the problem more and I think found the right solution (re-enabling filesystem redirection when loading libraries). I’ll send that patch in today.

Brendan


More information about the wine-devel mailing list