[PATCH] wininet/tests: Skip some FTP tests when no connection can be made.

[Francois Gouget]

On Thu, 24 Oct 2019, Sven Baars wrote:

> Signed-off-by: Sven Baars <sven.wine at gmail.com>
> ---
> This happens quite often, see
> 
> https://test.winehq.org/data/tests/wininet:ftp.html

I suspect this is because the VM is getting banned (fail2ban) after it 
has made too many failed connection attempts:

while wget -O/dev/null ftp://anonymous:IEUser@ftp.winehq.org/;do wget -O/dev/null ftp://foo:bar@ftp.winehq.org/;done


Probably a single run is fine because it stays under the limit. But when 
WineTest is run multiple times on the same VM (hence same IP address) in 
different configurations (particularly w8/w8adm or the various w1064 
variants) the failed attempts could add up resulting in a ban. 

Furthermore this would be pretty dependent on how much time passed 
between the wininet:ftp runs. It takes between 18 and 30 minutes to run 
WineTest so if the failed attempt counter is reset after 20 minutes (or 
if the ban did not expire yet) we'd see a pretty random behavior.

That may justify skipping but then we should add a comment if this 
explanation is indeed correct.

Or maybe the ftp.winehq.org configuration should be changed, but only 
Newman can say if it's ok security-wise.

-- 
Francois Gouget <fgouget at codeweavers.com>