[PATCH] qedit/mediadet: Check for failure from IEnumPins::Next().
Zebediah Figura
z.figura12 at gmail.com
Thu Oct 31 23:33:32 CDT 2019
Fixes a test crash when gstreamer is not present.
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
Thanks to Roberto Pungartnik for finding the crash.
dlls/qedit/mediadet.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/dlls/qedit/mediadet.c b/dlls/qedit/mediadet.c
index b7a5abb80c..1d70a86a5a 100644
--- a/dlls/qedit/mediadet.c
+++ b/dlls/qedit/mediadet.c
@@ -456,7 +456,12 @@ static HRESULT GetSplitter(MediaDetImpl *This)
IPin_Release(source_pin);
goto retry;
}
- IEnumPins_Next(pins, 1, &splitter_pin, NULL);
+ if (IEnumPins_Next(pins, 1, &splitter_pin, NULL) != S_OK)
+ {
+ IEnumPins_Release(pins);
+ IPin_Release(source_pin);
+ goto retry;
+ }
IEnumPins_Release(pins);
hr = IPin_Connect(source_pin, splitter_pin, NULL);
--
2.23.0
More information about the wine-devel
mailing list