[PATCH 3/4] localspl: Add support for monitors providing the MONITOR2 interface.

Dmitry Timoshkov dmitry at baikal.ru
Wed Sep 4 03:34:14 CDT 2019


Hi Huw,

Huw Davies <huw at codeweavers.com> wrote:

> > @@ -66,9 +66,9 @@ typedef struct {
> >      LPWSTR          dllname;
> >      PMONITORUI      monitorUI;
> >      LPMONITOR       monitor;
> > +    LPMONITOR2      monitor2;
> >      HMODULE         hdll;
> >      DWORD           refcount;
> > -    DWORD           dwMonitorSize;
> >  } monitor_t;
> 
> Hi Dmitry,
> 
> Is there a reason why we can't simply replace the MONITOR struct with
> a MONITOR2 struct?   It would require a bit more work at initialisation
> but then calling the functions would be rather simpler.

I considered that, and even have done an initial implementation that way.
However, the structures have different prototypes for some callbacks, and
in order to take care of this we'd need to create wrappers. I'd rather
decided to use an appropriate table instead.

-- 
Dmitry.



More information about the wine-devel mailing list