On 9/5/19 1:25 PM, Jactry Zeng wrote: > + init_media_engine(attributes, object); > + if (!object->mode) > + { > + free_media_engine(object); > + return MF_E_ATTRIBUTENOTFOUND; > } It would be better to have init helper return correct error code. Otherwise looks good.