[PATCH v2 3/4] localspl: Add support for monitors providing the MONITOR2 interface.

Dmitry Timoshkov dmitry at baikal.ru
Thu Sep 5 07:20:44 CDT 2019


Huw Davies <huw at codeweavers.com> wrote:

> Thanks for doing this, but this bit doesn't look quite right.
> 
> You don't need old_XcvDataPort at all since the prototypes of old and new
> are the same.  All you need to do is to call the appropriate XcvOpenPort
> function and then fall into common code that calls XcvDataPort.  [And if
> you really want to do it like you have, you need to call old_XvcDataPort
> in the else block].

Ah, right. Thanks for catching that.

-- 
Dmitry.



More information about the wine-devel mailing list