[PATCH] config.h must be the very first included file

evgeny litvinenko evgeny.v.litvinenko at gmail.com
Thu Sep 5 15:17:22 CDT 2019


Hi Alexandre.

On 9/5/19, Alexandre Julliard <julliard at winehq.org> wrote:
> Evgeny Litvinenko <evgeny.v.litvinenko at gmail.com> writes:
>
>> All included headers must be able to react on defines in config.h.
>> Also this removes gcc's warning messages - 'warning: "XYZ" redefined'.
>
> Where do you see that?
>
> --
> Alexandre Julliard
> julliard at winehq.org
>

On OpenIndiana Hipster 2019.04.
with flex 2.6.4

I am trying to build wine-4.15 and get messages like this
------------[ build log snippet ]------------
/usr/gcc/6/bin/gcc -c -o xslpattern.yy.o xslpattern.yy.c -I. \
  -I/home/src/oi-userland/components/runtime/wine/wine-4.15/dlls/msxml3
-I../../include \
  -I/home/src/oi-userland/components/runtime/wine/wine-4.15/include
-I/usr/include/libxml2 \
  -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing
-Wdeclaration-after-statement \
  -Wempty-body -Wignored-qualifiers -Wshift-overflow=2
-Wstrict-prototypes -Wtype-limits \
  -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith
-Wlogical-op \
  -fno-omit-frame-pointer -m32 -O3
In file included from
/home/src/oi-userland/components/runtime/wine/wine-4.15/dlls/msxml3/xslpattern.l:22:0:
../../include/config.h:1485:0: warning: "_FILE_OFFSET_BITS" redefined
 #define _FILE_OFFSET_BITS 64

In file included from /usr/include/stdio.h:37:0,
                 from xslpattern.yy.c:241:
/usr/include/sys/feature_tests.h:231:0: note: this is the location of
the previous definition
 #define _FILE_OFFSET_BITS 32
------------[ end build log snippet ]------------

I see that the patch needs more work as there are other places (e.g.
dlls/msxml3/xslpattern.l) where I get 'redefined' messages too.

Thanks,
Evgeny.



More information about the wine-devel mailing list