[PATCH 2/2] vbscript/tests: Test lack of newline parsing before End statements.

[Gabriel Ivăncescu]

On 9/6/19 4:30 PM, Jacek Caban wrote:
> Hi Gabriel,
> 
> On 9/5/19 2:48 PM, Gabriel Ivăncescu wrote:
>> Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
>> ---
>> Â  dlls/vbscript/tests/run.c | 99 +++++++++++++++++++++++++++++++++++++++
>> Â  1 file changed, 99 insertions(+)
>>
>> diff --git a/dlls/vbscript/tests/run.c b/dlls/vbscript/tests/run.c
>> index 15a8f10..87540a3 100644
>> --- a/dlls/vbscript/tests/run.c
>> +++ b/dlls/vbscript/tests/run.c
>> @@ -2077,6 +2077,104 @@ static void test_gc(void)
>> Â Â Â Â Â  IActiveScriptParse_Release(parser);
>> Â  }
>> +static void test_end_parse_without_nl(void)
>> +{
> 
> 
> How calling it test_parse_errors() with an intention of adding more 
> parser errors to the array in the future?
> 
> 
>> +Â Â Â  static const char *invalid[] =
>> +Â Â Â  {
>> +Â Â Â Â Â Â Â  /* If...End If */
>> +Â Â Â Â Â Â Â  "If 0 > 1 Then\n"
>> +Â Â Â Â Â Â Â  "Â Â Â  x = 0 End If\n",
>> +
>> +Â Â Â Â Â Â Â  /* While...End While */
>> +Â Â Â Â Â Â Â  "While False\n"
>> +Â Â Â Â Â Â Â  "Â Â Â  x = 0 End While\n",
>> +
>> +Â Â Â Â Â Â Â  /* While...Wend */
>> +Â Â Â Â Â Â Â  "While False\n"
>> +Â Â Â Â Â Â Â  "Â Â Â  x = 0 Wend\n",
>> +
>> +Â Â Â Â Â Â Â  /* Do While...Loop */
>> +Â Â Â Â Â Â Â  "Do While False\n"
>> +Â Â Â Â Â Â Â  "Â Â Â  x = 0 Loop\n",
>> +
>> +Â Â Â Â Â Â Â  /* Do Until...Loop */
>> +Â Â Â Â Â Â Â  "Do Until True\n"
>> +Â Â Â Â Â Â Â  "Â Â Â  x = 0 Loop\n",
>> +
>> +Â Â Â Â Â Â Â  /* Do...Loop While */
>> +Â Â Â Â Â Â Â  "Do\n"
>> +Â Â Â Â Â Â Â  "Â Â Â  x = 0 Loop While False\n",
>> +
>> +Â Â Â Â Â Â Â  /* Do...Loop Until */
>> +Â Â Â Â Â Â Â  "Do\n"
>> +Â Â Â Â Â Â Â  "Â Â Â  x = 0 Loop Until True\n",
>> +
>> +Â Â Â Â Â Â Â  /* Select...End Select */
>> +Â Â Â Â Â Â Â  "x = False\n"
>> +Â Â Â Â Â Â Â  "Select Case 42\n"
>> +Â Â Â Â Â Â Â  "Â Â Â  Case 0\n"
>> +Â Â Â Â Â Â Â  "Â Â Â Â Â Â Â  Call ok(False, \"unexpected case\")\n"
>> +Â Â Â Â Â Â Â  "Â Â Â  Case 42\n"
>> +Â Â Â Â Â Â Â  "Â Â Â Â Â Â Â  x = True End Select\n"
>> +Â Â Â Â Â Â Â  "Call ok(x, \"wrong case\")\n",
>> +
>> +        /* Class...End Class  (empty) */
>> +Â Â Â Â Â Â Â  "Class C End Class"
>> +Â Â Â  };
>> +Â Â Â  static const char *valid[] =
>> +Â Â Â  {
> 
> 
> Please add tests that are expected to parse correctly to lang.vbs instead.
> 
> 
> Thanks,
> 
> Jacek
> 

Hi Jacek,

Sure I'll do those changes in a moment, thanks for the review.