[PATCH 2/2] advpack/tests: Increase length of 'path' by 13.
Alexandre Julliard
julliard at winehq.org
Sat Sep 7 02:46:00 CDT 2019
Alex Henrie <alexhenrie24 at gmail.com> writes:
> I think that instead of making the buffer bigger, it would be better
> to add kernelbase to the IMPORTS line of
> dlls/advpack/tests/Makefile.in, include shlwapi.h in files.c, and then
> change lstrcatA to StrCatBuffA.
Arguably such buffer overflows in tests don't matter either way, but
using a function that would silently truncate the path is not an
improvement in general.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list