[PATCH 2/3] advpack/tests: Change sprintf to PathCombineA to avoid GCC warnings

Alex Henrie alexhenrie24 at gmail.com
Sat Sep 7 13:25:51 CDT 2019


Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
 dlls/advpack/tests/Makefile.in | 2 +-
 dlls/advpack/tests/files.c     | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/advpack/tests/Makefile.in b/dlls/advpack/tests/Makefile.in
index 9c1fecebe9..1c0d0a248e 100644
--- a/dlls/advpack/tests/Makefile.in
+++ b/dlls/advpack/tests/Makefile.in
@@ -1,5 +1,5 @@
 TESTDLL   = advpack.dll
-IMPORTS   = cabinet advapi32 advpack
+IMPORTS   = cabinet advapi32 advpack shlwapi
 
 C_SRCS = \
 	advpack.c \
diff --git a/dlls/advpack/tests/files.c b/dlls/advpack/tests/files.c
index 1851dc16f0..d96645aa72 100644
--- a/dlls/advpack/tests/files.c
+++ b/dlls/advpack/tests/files.c
@@ -22,6 +22,7 @@
 #include <windows.h>
 #include <advpub.h>
 #include <fci.h>
+#include <shlwapi.h>
 #include "wine/test.h"
 
 /* make the max size large so there is only one cab file */
@@ -162,7 +163,7 @@ static void test_AddDelBackupEntry(void)
     RemoveDirectoryA("backup");
 
     GetWindowsDirectoryA(windir, sizeof(windir));
-    sprintf(path, "%s\\basename.INI", windir);
+    PathCombineA(path, windir, "basename.INI");
 
     /* try a NULL backup dir, INI is created in the windows directory */
     res = pAddDelBackupEntry("one\0two\0three\0", NULL, "basename", AADBE_ADD_ENTRY);
-- 
2.23.0




More information about the wine-devel mailing list