[PATCH] winebus.sys: Don't WARN about backends we didn't build

Andrew Eikum aeikum at codeweavers.com
Wed Sep 11 09:25:38 CDT 2019


Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
---

Warning about IOHID missing on Linux is definitely uninteresting, and
I don't see any value in warning about the other backends either.

 dlls/winebus.sys/bus_iohid.c | 2 +-
 dlls/winebus.sys/bus_sdl.c   | 5 ++++-
 dlls/winebus.sys/bus_udev.c  | 1 -
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/dlls/winebus.sys/bus_iohid.c b/dlls/winebus.sys/bus_iohid.c
index 7933374007e..cda77e3011f 100644
--- a/dlls/winebus.sys/bus_iohid.c
+++ b/dlls/winebus.sys/bus_iohid.c
@@ -409,6 +409,7 @@ NTSTATUS iohid_driver_init(void)
         return STATUS_UNSUCCESSFUL;
     }
 
+    TRACE("Initialization successful\n");
     return STATUS_SUCCESS;
 }
 
@@ -429,7 +430,6 @@ void iohid_driver_unload( void )
 
 NTSTATUS iohid_driver_init(void)
 {
-    WARN("IOHID Support not compiled into Wine.\n");
     return STATUS_NOT_IMPLEMENTED;
 }
 
diff --git a/dlls/winebus.sys/bus_sdl.c b/dlls/winebus.sys/bus_sdl.c
index d24e21cff83..d3a1a19eeba 100644
--- a/dlls/winebus.sys/bus_sdl.c
+++ b/dlls/winebus.sys/bus_sdl.c
@@ -1145,9 +1145,13 @@ NTSTATUS sdl_driver_init(void)
     map_controllers = check_bus_option(&controller_mode, 1);
 
     if (!(events[0] = CreateEventW(NULL, TRUE, FALSE, NULL)))
+    {
+        WARN("CreateEvent failed\n");
         return STATUS_UNSUCCESSFUL;
+    }
     if (!(events[1] = CreateThread(NULL, 0, deviceloop_thread, events[0], 0, NULL)))
     {
+        WARN("CreateThread failed\n");
         CloseHandle(events[0]);
         return STATUS_UNSUCCESSFUL;
     }
@@ -1171,7 +1175,6 @@ sym_not_found:
 
 NTSTATUS sdl_driver_init(void)
 {
-    WARN("compiled without SDL support\n");
     return STATUS_NOT_IMPLEMENTED;
 }
 
diff --git a/dlls/winebus.sys/bus_udev.c b/dlls/winebus.sys/bus_udev.c
index d9311a9b030..20841b09ae0 100644
--- a/dlls/winebus.sys/bus_udev.c
+++ b/dlls/winebus.sys/bus_udev.c
@@ -1529,7 +1529,6 @@ error:
 
 NTSTATUS udev_driver_init(void)
 {
-    WARN("Wine was compiled without UDEV support\n");
     return STATUS_NOT_IMPLEMENTED;
 }
 
-- 
2.23.0




More information about the wine-devel mailing list