[PATCH] server: Fix use after free in add_committed_range (scan-build)

Alex Henrie alexhenrie24 at gmail.com
Wed Sep 11 22:05:06 CDT 2019


Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
 server/mapping.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/mapping.c b/server/mapping.c
index 0728fdc14f..6990a1913d 100644
--- a/server/mapping.c
+++ b/server/mapping.c
@@ -404,7 +404,7 @@ static void add_committed_range( struct memory_view *view, file_pos_t start, fil
         struct range *new_ptr = realloc( committed->ranges, new_size * sizeof(*new_ptr) );
         if (!new_ptr) return;
         committed->max = new_size;
-        committed->ranges = new_ptr;
+        ranges = committed->ranges = new_ptr;
     }
     memmove( &ranges[i + 1], &ranges[i], (committed->count - i) * sizeof(*ranges) );
     ranges[i].start = start;
-- 
2.23.0




More information about the wine-devel mailing list